[PATCH] usb: gadget: ether: split start/stop from init/halt

[Niel Fourie]

Hi Marek

On 18/12/2022 02:51, Marek Vasut wrote:
> On 12/16/22 17:35, lusus at denx.de wrote:
>> Hi Marek,
> 
> Hi,
> 
> [...]
> 
>>> Should "[PATCH v2] net: eth-uclass: revalidate priv after stop() in
>>> eth_halt()" be dropped ? It seems this patch fully replaces it.
>>
>> That old patch only exists for in case there were showstopper issues 
>> with the new patch which I missed, or as a stopgap if major changes 
>> were needed first. I did my best to test the new patch on the hardware 
>> I have, but if any other gadget drivers were to misbehave, I would not 
>> know about it, for example. But if you are happy with this new patch, 
>> that old patch could gladly be dropped.
> 
> The new patch is by far preferable. If you can sort out the 
> network_started comment, I would like to pick this via usb/next.

I did some more testing and I found that keeping network_started as it 
is works best, so I did not change it for v2 of this patch.

Unfortunately during local testing (on imx8mp), I uncovered an issue in 
the dwc3 gadget driver causing it to hang. I have a workaround, but I am 
still looking into fixing the root cause, and that would have to be 
fixed in a separate patch series.

Similar issues might also still crop up with other gadget drivers.

Best regards,
Niel Fourie

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-21 Fax: +49-8142-66989-80  Email: lusus at denx.de