[PATCH 3/5] usb: dwc3-generic: Add dependency on SIMPLE_BUS

[Kunihiko Hayashi]

Hi Marek,

Thank you for reviewing.

On 2023/01/23 10:42, Marek Vasut wrote:
> On 1/23/23 01:47, Kunihiko Hayashi wrote:
>> The glue driver doesn't do or offer actively anything, SIMPLE_BUS is
>> more preferable to represent the driver.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko at socionext.com>
>> ---
>>    drivers/usb/dwc3/Kconfig | 4 ++--
>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
>> index f010291d02..dadaa083e7 100644
>> --- a/drivers/usb/dwc3/Kconfig
>> +++ b/drivers/usb/dwc3/Kconfig
>> @@ -25,14 +25,14 @@ config USB_DWC3_OMAP
>>    
>>    config USB_DWC3_GENERIC
>>    	bool "Generic implementation of a DWC3 wrapper (aka dwc3 glue)"
>> -	depends on DM_USB && USB_DWC3 && MISC
>> +	depends on DM_USB && USB_DWC3 && (MISC || SIMPLE_BUS)
> 
> I'm afraid I don't understand why this change is needed for all variants
> of DWC3.

Although dwc3-generic is declared as UCLASS_NOP, the similar glue driver
dwc3-meson-glx is declared as UCLASS_SIMPLE_BUS.

> Is this needed for socionext dwc3 variant to handle the simple-mfd in
> e.g. arch/arm/dts/uniphier-pxs3.dtsi :
> 
> 614 usb-glue at 65b00000 {
> 615     compatible = "socionext,uniphier-pxs3-dwc3-glue",
> 616              "simple-mfd";
> 
> ?

In case of U-Boot, the glue driver is probed by:

     /* FIXME: U-Boot own node */
     usb at 65b00000 {
             compatible = "socionext,uniphier-pxs3-dwc3";

And dwc3-uniphier is also declared as UCLASS_SIMPLE_BUS.
Even if using "simple-mfd", this is included in drivers/core/simple-bus.c
which is declared as UCLASS_SIMPLE_BUS.

Thank you,

---
Best Regards
Kunihiko Hayashi