[PATCH 4/5] arm64: dts: qcom: Fix SPMI arbiter regs and reg-names

[Sumit Garg]

On Sat, 21 Jan 2023 at 08:38, Alexey Minnekhanov
<alexeymin at postmarketos.org> wrote:
>
> On 2023-01-19 11:47, Sumit Garg wrote:
> > On Mon, 16 Jan 2023 at 06:04, Alexey Minnekhanov
> > <alexeymin at postmarketos.org> wrote:
> >>
> >> Now that reg-names is required, specify them, and use correct
> >> addresses for SPMI arbiter regs, taken from Linux dts [1] [2].
> >>
> >> [1] https://elixir.bootlin.com/linux/v6.1.5/source/arch/arm64/boot/dts/qcom/qcs404.dtsi#L739
> >> [2] https://elixir.bootlin.com/linux/v6.1.5/source/arch/arm64/boot/dts/qcom/sdm845.dtsi#L4896
> >>
> >
> > Since you have already aligned the u-boot driver to work with Linux DT
> > binding, we should rather exactly match spmi DT nodes as in Linux dts
> > files.
> >
> > -Sumit
> >
>
> It can be done easier for sdm845, but there is no exact file named
> qcs404-evb.dts in Linux with spmi node in it. File structure in Linux
> is a bit different. There qcs404-evb.dtsi includes qcs404.dtsi.

Once we have all the u-boot drivers (pending ones are pinctrl, uart
etc.) aligned to Linux DT binding then we should be able to directly
import those dts/dtsi files.

>
> I can take spmi node from Linux's qcs404.dtsi and put it here in
> qcs404-evb.dts, but it won't be 1:1 match to Linux DT.
>
> If that would be OK, I can do it in v2?

Yeah that's fine with me.

-Sumit

>
> --
> Alexey Minnekhanov