[PATCH] spl: Drop unwanted return in spl_fit_upload_fpga()

Oleksandr Suvorov cryosay at gmail.com
Tue Jan 24 12:40:24 CET 2023


On Tue, Jan 24, 2023 at 12:56 PM Simon Glass <sjg at chromium.org> wrote:
>
> This was added by mistake and renders the function useless. Fix it.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> Fixes: 33c60a38bb9 ("trace: Use notrace for short")
> Reported-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier-oss at weidmueller.com>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov at foundries.io>

> ---
>
>  common/spl/spl_fit.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c
> index 9ae3e5e35d4..c51482b3b65 100644
> --- a/common/spl/spl_fit.c
> +++ b/common/spl/spl_fit.c
> @@ -591,7 +591,6 @@ static int spl_fit_upload_fpga(struct spl_fit_info *ctx, int node,
>                         debug("Ignoring compatible = %s property\n",
>                               compatible);
>         }
> -       return 0;
>
>         ret = fpga_load(devnum, (void *)fpga_image->load_addr,
>                         fpga_image->size, BIT_FULL, flags);
> --
> 2.39.0.246.g2a6d74b583-goog
>


-- 
Best regards
Oleksandr

Oleksandr Suvorov
cryosay at gmail.com


More information about the U-Boot mailing list