[PATCH v5 3/4] eficonfig: add vertical scroll support

[Heinrich Schuchardt]

On 1/24/23 07:56, Masahisa Kojima wrote:
> The current eficonfig menu does not support vertical scroll,
> so it can not display the menu entries greater than
> the console row size.
>
> This commit add the vertial scroll support.
> The console size is retrieved by
> SIMPLE_TEXT_OUTPUT_PROTOCOL.QueryMode() service, then
> calculates the row size for menu entry by subtracting
> menu header and description row size from the console row size.
> "start" and "end" are added in the efimenu structure.
> "start" keeps the menu entry index at the top, "end" keeps
> the bottom menu entry index. item_data_print() menu function
> only draws the menu entry between "start" and "end".
>
> This commit also fixes the issue that "Save" and "Quit"
> entries can be moved by BKEY_PLUS in change boot order menu.
>
> Signed-off-by: Masahisa Kojima <masahisa.kojima at linaro.org>

Hello Masahisa,

my example with 100 boot options works fine now. I will get that series
merged.

When I edit the boot order and want to save the changes I have to scroll
down up to INT_MAX lines to reach the line with "Save". Can't we just
use CTRL+S for saving in a future patch?

"ESC/CTRL+C to quit" is misleading:
On the sandbox called without "--terminal raw" CTRL+C leaves U-Boot. How
about removing "/CTRL+C" from that text?

Best regards

Heinrich