[PATCH] powerpc/mpc85xx: use board env file for socrates board

[Heiko Schocher]

Hello Tom,

On 26.01.23 15:30, Tom Rini wrote:
> On Thu, Jan 26, 2023 at 08:46:21AM +0100, Heiko Schocher wrote:
> 
>> as Tom suggested get rid of CFG_EXTRA_ENV_SETTINGS and
>> enable CONFIG_ENV_SOURCE_FILE and use text file
>>
>> board/socrates/socrates.env
>>
>> which contains the default environment. While at it,
>> cleanup the default Environment.
>>
>> Signed-off-by: Heiko Schocher <hs at denx.de>
>> Suggested-by: Tom Rini <trini at konsulko.com>
> [snip]
>> +baudrate=CONFIG_BAUDRATE
> [snip]
>> +bootcmd=CONFIG_BOOTCOMMAND
>> +bootdelay=CONFIG_BOOTDELAY
> [snip]
>> +mtdids=CONFIG_MTDIDS_DEFAULT
>> +mtdparts=CONFIG_MTDPARTS_DEFAULT
> 
> These aren't needed as they're in env_default.h

Correct! I had tries with CONFIG_USE_DEFAULT_ENV_FILE,
and whit it, the default settings in include/env_default.h
are not active ... I rework the patch, thanks!

>> @@ -70,6 +70,7 @@ CONFIG_MTDIDS_DEFAULT="nor0=fe000000.nor_flash,nand0=socrates_nand"
>>  CONFIG_MTDPARTS_DEFAULT="mtdparts=fe000000.nor_flash:13312k(system1),13312k(system2),5120k(data),128k(env),128k(env-red),768k(u-boot);socrates_nand:256M(ubi-data1),-(ubi-data2)"
>>  # CONFIG_CMD_IRQ is not set
>>  CONFIG_OF_CONTROL=y
>> +CONFIG_ENV_SOURCE_FILE="socrates"
>>  CONFIG_ENV_IS_NOWHERE=y
>>  CONFIG_ENV_IS_IN_FLASH=y
>>  CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
> 
> And that shouldn't be needed as it's the default name I believe.

Yep, I drop it.

Thanks for the review.

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de