[PATCH 02/88] treewide: Correct invalid Kconfig syntax and warnings

Tom Rini trini at konsulko.com
Fri Jan 27 14:45:41 CET 2023


On Mon, Jan 23, 2023 at 02:59:05PM -0700, Simon Glass wrote:

> In several places a 'select' is used to select a choice, which is not
> supported by Kconfig. In other places, the filename for the 'source'
> command is not in quites.
> 
> Fix these two problems throughout the tree, so that kconfiglib does not
> show any more warnings.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>

OK, to summarize what I just said in another email and clarify future
work. Please first split this patch in to its own series that corrects
each type of problem, per commit. The missing quotes for example, and
then the extra whitespace ones. Next, commenting out a select is wrong,
and each case needs to be better understood / fixed. I'm honestly not
sure if asking endianness for MIPS is right and if we should select that
from boards too, like ARC, but probably. The ARC_MMU one also should
just not be asked, I suspect, but as a separate patch where you cc
Alexey, we'll find out :)  And so on, for each.  Thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230127/1e10ea72/attachment.sig>


More information about the U-Boot mailing list