[PATCH 1/1] common: remove "impossible condition #876" message

[Simon Glass]

Hi Heinrich,

On Sun, 29 Jan 2023 at 15:32, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> Function cli_ch_esc() supports only a small subset of the escape sequences
> used by terminals. Don't nag the user with a message if an unsupported
> escape sequence is met.
>
> Fixes: b08e9d4b6632 ("cli: Move readline character-processing to a state machine")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> ---
>  common/cli_getch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

The bug is in the calling code, though. See my previous email.

>
> diff --git a/common/cli_getch.c b/common/cli_getch.c
> index 87c23edcf4..ebda3a1236 100644
> --- a/common/cli_getch.c
> +++ b/common/cli_getch.c
> @@ -198,7 +198,7 @@ int cli_ch_process(struct cli_ch_state *cch, int ichar)
>                         cch->esc_save[cch->esc_len] = ichar;
>                         cch->esc_len = 1;
>                 } else {
> -                       puts("impossible condition #876\n");
> +                       /* TODO: support more escape sequences */
>                         cch->esc_len = 0;
>                 }
>                 return 0;
> --
> 2.38.1
>

Regards,
Simon