CONFIG_IS_ENABLED vs IS_ENABLED

Tom Rini trini at konsulko.com
Mon Jan 30 18:18:07 CET 2023


On Sat, Jan 28, 2023 at 09:25:54AM -0800, Troy Kisky wrote:
> Thanks Tom,
> 
> I cleaned up the PR based on the CI results. Here's my current changes.
> 
> Author: Troy Kisky <troy.kisky at boundarydevices.com>
> Date:   Fri Jan 27 11:03:11 2023 -0800
> 
>     dm: device-internal: use EVENT instead of DM_EVENT, because
> event_notify is built for EVENT
> 
>     Signed-off-by: Troy Kisky <troy.kisky at boundarydevices.com>
> 
> diff --git a/include/dm/device-internal.h b/include/dm/device-internal.h
> index f31c4702086..2e725aa9416 100644
> --- a/include/dm/device-internal.h
> +++ b/include/dm/device-internal.h
> @@ -431,7 +431,7 @@ static inline void devres_release_all(struct udevice
> *dev)
> 
>  static inline int device_notify(const struct udevice *dev, enum event_t
> type)
>  {
> -#if CONFIG_IS_ENABLED(DM_EVENT)
> +#if CONFIG_IS_ENABLED(EVENT)
>         return event_notify(type, &dev, sizeof(dev));
>  #else
>         return 0;

Given 448e2b6327d0 ("event: Correct dependencies on the EVENT
framework") I'm a little worried about this change here and want to be
extra sure it doesn't break something inadvertently.  Aside from that,
are you able to post your series?  And incorporate your checking script
in to .gitlab-ci.yml / .azure-pipline.yml ?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230130/310fb4ab/attachment.sig>


More information about the U-Boot mailing list