[PATCH u-boot 3/3] tools: imagetool: Skip autodetection of gpimage type

[Tom Rini]

On Mon, Jan 30, 2023 at 08:50:15AM -0700, Simon Glass wrote:
> On Sun, 29 Jan 2023 at 09:46, Pali Rohár <pali at kernel.org> wrote:
> >
> > gpimage type requires only that two first 32-bit words of data file are
> > non-zero. So basically every random data file can be guessed and verified
> > as gpimage. So completely skip gpimage type from image autodetection code
> > to prevent lot of false positive results. Data file with gpimage type can
> > be still verified and parsed by explicitly specifying -T gpimage.
> >
> > Signed-off-by: Pali Rohár <pali at kernel.org>
> > ---
> >  tools/imagetool.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>

I see we've had problems with gpimage before too. This seems reasonable
but I'm adding Nishanth here too, as the current interested person in
keystone2 platforms, to see if there's any other / better ways to
address this problem.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230130/3c52ac73/attachment.sig>