[PATCH 2/5] usb: dwc3-generic: Return early when there is no child node

Marek Vasut marex at denx.de
Mon Jun 5 12:12:48 CEST 2023


On 5/30/23 12:26, Jonas Karlman wrote:
> The call to device_find_first_child always return 0, change to return
> early when there is no child node.
> 
> Signed-off-by: Jonas Karlman <jonas at kwiboo.se>
> ---
>   drivers/usb/dwc3/dwc3-generic.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c
> index 66da5a8d6f8c..c28ad47bddd8 100644
> --- a/drivers/usb/dwc3/dwc3-generic.c
> +++ b/drivers/usb/dwc3/dwc3-generic.c
> @@ -558,9 +558,9 @@ int dwc3_glue_probe(struct udevice *dev)
>   			return ret;
>   	}
>   
> -	ret = device_find_first_child(dev, &child);
> -	if (ret)
> -		return ret;
> +	device_find_first_child(dev, &child);
> +	if (!child)
> +		return 0;
>   
>   	if (glue->clks.count == 0) {
>   		ret = dwc3_glue_clk_init(child, glue);

If this is a fix, then please send this separately, so I can pick it for 
current release.


More information about the U-Boot mailing list