[PATCH v7 1/4] Move bootorder and bootoption apis to lib

Heinrich Schuchardt xypron.glpk at gmx.de
Tue Jun 6 17:12:50 CEST 2023



Am 6. Juni 2023 16:39:47 MESZ schrieb Raymond Mao <raymond.mao at linaro.org>:
>Hi Heinrich,
>
>> With this patch applied to origin/next I get:
>>
>> ./lib/efi_loader/efi_bootmgr.c:651:Unexpected indentation.
>>
>> We have
>> doc/api/efi.rst:44:
>> .. kernel-doc:: lib/efi_loader/efi_bootmgr.c
>>
>> So this file goes into documentation.
>>
>> Please, provide a follow up patch to fix 'make htmldocs'.
>> See https://u-boot.readthedocs.io/en/latest/build/documentation.html .
>I think it is better to put this fix into patch 'v8 1/4' if you agree,
>as this 'Unexpected indentation' was introduced when function
>'###_media_device_boot_option' was moved from eficonfig to efi_bootmgr
>
>Regards,
>Raymond


Ok with me. Please, mention it in the commit message.

Best regards

Heinrich


More information about the U-Boot mailing list