bootmenu regression

Pali Rohár pali at kernel.org
Sun Jun 11 15:11:40 CEST 2023


On Saturday 10 June 2023 16:31:06 Mark Kettenis wrote:
> Hi Simon,
> 
> In commit 32bab0eae51 you added a
> 
>   #define ansi 0
> 
> and put the code that positions the cursor to print the "Hit any key
> to stop autoboot" message behind an
> 
>   if (ansi)
> 
> condition.  As a result that message is now printed in whatever place
> the cursor happens to be, which happens to be the last menu entry that
> gets printed, making that menu option confusing.
> 
> The commit message makes no mention of any intended side-effect of the
> change, so am I right assuming that this is debugging code that
> accidentally made it out of your tree?

Hello! This is known issue and it broke support for bootmenu (tested on
nokia n900). I reported it month ago, but there was no reaction for it.
So now I sent a revert patches, to make bootmenu work again. I guess
that this issue can be later fixed properly.


More information about the U-Boot mailing list