[PATCH v2 3/7] usb: dwc3-generic: Restrict single ctrl node for RK3328

Jagan Teki jagan at amarulasolutions.com
Sun Jun 11 18:25:25 CEST 2023


On Sun, Jun 11, 2023 at 8:23 PM Peter Robinson <pbrobinson at gmail.com> wrote:
>
> On Tue, Jun 6, 2023 at 6:10 PM Jagan Teki <jagan at amarulasolutions.com> wrote:
> >
> > Like Rockchip RK3568, the RK3328 also have single node to
> > represent the glue and ctrl for USB 3.0.
> >
> > So, use the driver data to use single ctrl for RK3328 DWC3.
> >
> > Reviewed-by: Marek Vasut <marex at denx.de>
> > Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
> > ---
> > Changes for v2:
> > - collect Marek RB
> >
> >  drivers/usb/dwc3/dwc3-generic.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c
> > index 5f8c2613a4..dcf420bafd 100644
> > --- a/drivers/usb/dwc3/dwc3-generic.c
> > +++ b/drivers/usb/dwc3/dwc3-generic.c
> > @@ -621,7 +621,7 @@ static const struct udevice_id dwc3_glue_ids[] = {
> >         { .compatible = "ti,dwc3", .data = (ulong)&ti_ops },
> >         { .compatible = "ti,am437x-dwc3", .data = (ulong)&ti_ops },
> >         { .compatible = "ti,am654-dwc3" },
> > -       { .compatible = "rockchip,rk3328-dwc3" },
> > +       { .compatible = "rockchip,rk3328-dwc3", .data = (ulong)&rk_ops },
>
> This doesn't build for me against master due to rk_ops not being
> defined, is this against another branch or builds upon another patch
> set?

This, on top of
https://patchwork.ozlabs.org/project/uboot/patch/20230530102617.3413183-5-jonas@kwiboo.se/

Jagan.


More information about the U-Boot mailing list