[PATCH 2/6] xilinx: zynq: Add missing prototype for zynqmp_mmio_write

Michal Simek michal.simek at amd.com
Mon Jun 12 08:38:24 CEST 2023



On 6/9/23 11:21, Ashok Reddy Soma wrote:
> From: Algapally Santosh Sagar <santoshsagar.algapally at amd.com>
> 
> Add missing prototype to fix the sparse warning, warning: no
> previous prototype for 'zynqmp_mmio_write' [-Wmissing-prototypes].
> 
> Signed-off-by: Algapally Santosh Sagar <santoshsagar.algapally at amd.com>
> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma at amd.com>
> ---
> 
>   arch/arm/mach-zynq/include/mach/sys_proto.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-zynq/include/mach/sys_proto.h b/arch/arm/mach-zynq/include/mach/sys_proto.h
> index 268ec50ad8..74f9665fbb 100644
> --- a/arch/arm/mach-zynq/include/mach/sys_proto.h
> +++ b/arch/arm/mach-zynq/include/mach/sys_proto.h
> @@ -16,5 +16,6 @@ extern u32 zynq_slcr_get_idcode(void);
>   extern int zynq_slcr_get_mio_pin_status(const char *periph);
>   extern void zynq_ddrc_init(void);
>   extern unsigned int zynq_get_silicon_version(void);
> +int zynqmp_mmio_write(const u32 address, const u32 mask, const u32 value);
>   
>   #endif /* _SYS_PROTO_H_ */


This should be done differently.
It should go to include/zynqmp_firmware.h
and remove it from platform sys_proto.h file.

Thanks,
Michal


More information about the U-Boot mailing list