[PATCH] core: read: fix dev_read_addr_size()

Simon Glass sjg at chromium.org
Mon Jun 12 23:17:42 CEST 2023


On Thu, 1 Jun 2023 at 15:11, John Keeping <john at metanate.com> wrote:
>
> The behaviour of dev_read_addr_size() is surprising as it does not
> handle #address-cells and #size-cells but instead hardcodes the values
> based on sizeof(fdt_addr_t).
>
> This is different from dev_read_addr_size_index() and
> dev_read_addr_size_name() both of which do read the cell sizes from the
> device tree.
>
> Since dev_read_addr_size() is only used by a single driver and this
> driver is broken when CONFIG_FDT_64BIT does not match the address size
> in the device tree, fix the function to behave like all of the other
> similarly named functions.  Drop the property name argument as the only
> caller passes "reg" and this is the expected property name matching the
> other similarly named functions.
>
> Signed-off-by: John Keeping <john at metanate.com>
> ---
>  drivers/core/read.c            |  5 ++---
>  drivers/reset/reset-rockchip.c |  2 +-
>  include/dm/read.h              | 12 +++---------
>  3 files changed, 6 insertions(+), 13 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>
Tested-by: Simon Glass <sjg at chromium.org>  # chromebook_jerry
Tested-by: Simon Glass <sjg at chromium.org>  # chromebook_bob


More information about the U-Boot mailing list