[PATCH v2 4/4] net: add NFSv1 support

[Christian Gmeiner]

Am Di., 13. Juni 2023 um 13:24 Uhr schrieb Peter Robinson
<pbrobinson at gmail.com>:
>
> > > To clarify a fact: I am happy with the patch. I am unhappy with the
> > > wrong "naming" that my old
> > > employer used and influenced this patch. Also the company is shipping
> > > thousands of devices per
> > > year where these patches are used.
> >
> > Further clean-ups and clarifications to the support here in terms of
> > what it does and doesn't provide are good.  But to the point on reviews,
> > yes, I do wish we had more people interested in various areas, and with
> > time to devote to reviewing code as well. Sadly, we don't always, and I
> > took this particular set of patches as being small enough of a global
> > impact while (hopefully!) making future contributions both in this area
> > and the related platforms using it more likely.
>
> I understand your sentiment but even feedback for things like having
> it behind a Kconfig option to opt into, especially for a default on
> option, and CI weren't even addressed, it was just landed without
> additional revisions. I feel some of those negate the "just land it"
> sentiment.
>

Let's move a little bit back in time when I send out V2 of this
series. When reading the cover
letter thread again
https://lore.kernel.org/u-boot/20230310095155.29832-1-christian.gmeiner@gmail.com/
you had a very strong opinion against it Peter.

After that I lost motivation on working on this series as I had the
feeling you will always
be against adding legacy stuff that is still used today. Tom had taken
it and committed it to the master
branch.

Peter, If you feel better let's revert all the changes.

-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info/privacypolicy