[PATCH v2] sandbox: fix a compilation error

Simon Glass sjg at chromium.org
Tue Jun 13 22:12:28 CEST 2023


Hi,

On Tue, 13 Jun 2023 at 18:33, Tom Rini <trini at konsulko.com> wrote:
>
> On Tue, Jun 13, 2023 at 07:05:52PM +0300, Sergei Antonov wrote:
> > On Tue, 13 Jun 2023 at 17:58, Simon Glass <sjg at chromium.org> wrote:
> > > The problem with this is it then cannot be built on non-sandbox
> > > boards. I think v1 was OK.
> >
> > Before the patch as well as after the patch:
> > if CONFIG_SANDBOX_SDL
> >   declaration of sandbox_sdl_set_bpp()
> > else
> >   definition of sandbox_sdl_set_bpp() returning error
> > end
> > This patch only moves code to another header file in arch/sandbox/include/asm.
> > How can a non-sandbox build fail because of this patch?
>
> Right, test/dm/video.c is for sandbox-only.

OK, yes.

Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Simon


More information about the U-Boot mailing list