[PATCH u-boot 0/3] Revert broken Bootmenu commits

[Tom Rini]

On Sun, Jun 11, 2023 at 02:53:21PM +0200, Pali Rohár wrote:

> These 3 commits broke support for U-Boot Bootmenu on Nokia N900.
> Issues were reported more than month ago, but nobody reacted to them.
> So revert these broken commits for now, to fix U-Boot Bootmenu support.
> 
> With these revered commits, U-Boot Bootmenu from master branch is
> working fine again on Nokia N900.
> 
> Pali Rohár (3):
>   Revert "video: Enable VIDEO_ANSI by default only with EFI"
>   Revert "menu: Factor out menu-keypress decoding"
>   Revert "menu: Make use of CLI character processing"
> 
>  cmd/bootmenu.c        |   9 ++--
>  cmd/eficonfig.c       |  12 ++---
>  common/cli_getch.c    |  12 ++---
>  common/menu.c         | 122 ++++++++++++++++++++++++++----------------
>  drivers/video/Kconfig |   7 +--
>  include/cli.h         |   4 +-
>  include/menu.h        |  17 +-----
>  7 files changed, 91 insertions(+), 92 deletions(-)

Following up over here, while
https://patchwork.ozlabs.org/project/uboot/patch/20230612201434.861700-1-sjg@chromium.org/
addresses some of the issues, but not all (as it clearly isn't working
in all of the cases Pali has explained), looking in to the VIDEO_ANSI
part of this too, all three of these reverts are related seemingly to
something escape-character related.  I'm not taking any of the revert
commits in just yet, but will by the next -rc if we don't have something
that fixes all of the issues.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230614/9fdc8cd6/attachment.sig>