[PATCH v7 2/2] phy: rockchip-inno-usb2: Implement clock operations for usb2phy clock

Jagan Teki jagan at amarulasolutions.com
Mon Jun 19 08:34:51 CEST 2023


Hi Kever,

On Tue, Jun 6, 2023 at 6:24 AM Kever Yang <kever.yang at rock-chips.com> wrote:
>
>
> On 2023/6/5 23:06, Xavier Drudis Ferran wrote:
> > This clock doesn't seem needed but appears in a phandle list used by
> > ehci-generic.c to bulk enable it. The phandle list comes from linux,
> > where it is needed for suspend/resume to work [1].
> >
> > My tests give the same results with or without this patch, but Marek
> > Vasut found it weird to declare an empty clk_ops [2].
> >
> > So I adapted the code from linux 6.1-rc8 so that it hopefully works
> > if it ever has some user. For now, without real use, it seems to
> > at least not give any errors when called.
> >
> > Link: [1] https://lkml.kernel.org/lkml/1731551.Q6cHK6n5ZM@phil/T/
> >        [2] https://patchwork.ozlabs.org/project/uboot/patch/Y5IWpjYLB4aXMy9o@localhost/
> >
> > Cc: Simon Glass <sjg at chromium.org>
> > Cc: Philipp Tomsich <philipp.tomsich at vrull.eu>
> > Cc: Kever Yang <kever.yang at rock-chips.com>
> > Cc: Lukasz Majewski <lukma at denx.de>
> > Cc: Sean Anderson <seanga2 at gmail.com>
> > Cc: Marek Vasut <marex at denx.de>
> > Cc: Christoph Fritz <chf.fritz at googlemail.com>
> > Cc: Jagan Teki <jagan at amarulasolutions.com>
> >
> > Signed-off-by: Xavier Drudis Ferran <xdrudis at tinet.cat>
> Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Please merge these two asap. Better would these two be part of the
coming release?

Thanks,
Jagan.


More information about the U-Boot mailing list