[PATCH] phy: rockchip-inno-usb2: cleanup comments and make ops static

Xavier Drudis Ferran xdrudis at tinet.cat
Mon Jun 19 12:23:52 CEST 2023


El Mon, Jun 19, 2023 at 02:58:50PM +0530, Jagan Teki deia:
> On Mon, Jun 19, 2023 at 2:39 PM Marek Vasut <marex at denx.de> wrote:
> >
> > On 6/19/23 09:24, Xavier Drudis Ferran wrote:
> > > Thanks to Jagan Teki for noting that three functions should be static
> > > and comments from uclass_clk are redundant.

[...]

> >
> > Why is the documentation dropped ?
> 
> As these comments seem redundant as in clk-uclass.h definitions, so I
> asked to drop the same from the driver.
> 
> Xavier, can you add the details in the commit message?
> 
> Jagan.

Which details ? The commit message says "comments from uclass_clk are
redundant" . What should it say ? Do you want me to copy the deleted
comments to the commit message ??



More information about the U-Boot mailing list