[PATCH v2] board_f: Relocate fdt even if GD_FLG_SKIP_RELOC is set

Simon Glass sjg at chromium.org
Tue Jun 20 16:36:49 CEST 2023


On Tue, 20 Jun 2023 at 11:50, Kunihiko Hayashi
<hayashi.kunihiko at socionext.com> wrote:
>
> In case of OF_SEPARATE (!OF_EMBED), the devicetree blob is placed
> after _end, and fdt_find_separate() always returns _end. There is
> a .bss section after _end and the section is cleared before relocation.
>
> When GD_FLG_SKIP_RELOC is set, relocation is skipped, so the blob is
> still in .bss section, but will be cleared. As a result, the devicetree
> become invalid.
>
> To avoid this issue, should relocate it regardless of GD_FLG_SKIP_RELOC
> in reloc_fdt().
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko at socionext.com>
> ---
>  common/board_f.c | 2 --
>  1 file changed, 2 deletions(-)
>
> Changes since v1:
> - Remove condition for skipping fdt relocation (always relocate)
>

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list