[PATCH v2 1/4] sysinfo: Add IDs for board id and revision

[Simon Glass]

Hi Detlev,

On Wed, 28 Jun 2023 at 20:32, Detlev Casanova
<detlev.casanova at collabora.com> wrote:
>
> These IDs will be used by the sysinfo command. The new IDs are:
>  * SYSINFO_ID_BOARD_ID: The board ID as an integer
>  * SYSINFO_ID_BOARD_REVISION: The board revision as a string
>
> Signed-off-by: Detlev Casanova <detlev.casanova at collabora.com>
> ---
>  include/sysinfo.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/include/sysinfo.h b/include/sysinfo.h
> index b140d742e93..43d9e91212d 100644
> --- a/include/sysinfo.h
> +++ b/include/sysinfo.h
> @@ -47,6 +47,11 @@ enum sysinfo_id {
>         /* For show_board_info() */
>         SYSINFO_ID_BOARD_MODEL,
>
> +       /* For sysinfo command */
> +       SYSINFO_ID_BOARD_ID,
> +       SYSINFO_ID_BOARD_REVISION_MAJOR,
> +       SYSINFO_ID_BOARD_REVISION_MINOR,

Please mention that these are strings. Are they?

Also how about REV instead of REVISION as it is shorter

> +
>         /* First value available for downstream/board used */
>         SYSINFO_ID_USER = 0x1000,
>  };
> --
> 2.39.3
>

Regards,
Simon