[PATCH 2/2] spi: spi-mem: perform odd len check only while writing data

Nikhil M Jain n-jain1 at ti.com
Wed Mar 1 08:43:46 CET 2023

From: Dhruva Gole <d-gole at ti.com>

in spi_mem_dtr_supports_op we have a check for allowing only even number
of bytes to be r/w. Odd bytes writing can be a concern while writing
data to a flash for example because 8 DTR mode doesn't support it.
However, reading ODD Bytes even  though may not be physically possible
we can still allow for it because it will not have serious implications
on any critical registers being overwritten since they are just reads.

Cc: Vaishnav Achath <vaishnav.a at ti.com>
Cc: Pratyush Yadav <pratyush at kernel.org>
Cc: Vignesh Raghavendra <vigneshr at ti.com>
Tested-by: Nikhil M Jain <n-jain1 at ti.com>
Signed-off-by: Dhruva Gole <d-gole at ti.com>
 drivers/spi/spi-mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c
index 57a36f31a5..b7eca58359 100644
--- a/drivers/spi/spi-mem.c
+++ b/drivers/spi/spi-mem.c
@@ -185,7 +185,7 @@ bool spi_mem_dtr_supports_op(struct spi_slave *slave,
 	 * Transactions of odd length do not make sense for 8D-8D-8D mode
 	 * because a byte is transferred in just half a cycle.
-	if (op->data.dir != SPI_MEM_NO_DATA &&
+	if (op->data.dir != SPI_MEM_NO_DATA && op->data.dir != SPI_MEM_DATA_IN &&
 	    op->data.buswidth == 8 && op->data.nbytes % 2)
 		return false;

More information about the U-Boot mailing list