[PATCH] pinctrl: rockchip: support rk3588 pinctrl

[Jagan Teki]

On Wed, 1 Mar 2023 at 14:54, Eugen Hristev <eugen.hristev at collabora.com> wrote:
>
> On 3/1/23 10:53, Jagan Teki wrote:
> > On Wed, 1 Mar 2023 at 14:01, Eugen Hristev <eugen.hristev at collabora.com> wrote:
> >>
> >> From: Jianqun Xu <jay.xu at rock-chips.com>
> >>
> >> Add support for Rockchip rk3588 variant of pinctrl.
> >>
> >> The driver is adapted from the Linux driver.
> >>
> >> Signed-off-by: Jianqun Xu <jay.xu at rock-chips.com>
> >> [eugen.hristev at collabora.com:
> >> port to latest U-boot, bring more changes from Linux]
> >> Signed-off-by: Eugen Hristev <eugen.hristev at collabora.com>
> >> ---
> >
> > It would be good if it tested with any function, does it?
> >
> > Jagan.
>
> Hello Jagan,
>
> To test it with GPIO, I also added this patch to my test bench :
>
> https://patchwork.ozlabs.org/project/uboot/patch/20230213222742.135093-8-macroalpha82@gmail.com/
>
> And then, I was able to test with GPIO : powering up a LED , powering it
> down, also tested USB host by having the VBUS powered up by GPIO /
> powered down.
>
> Other pinctrl functions tested were to boot from SD-Card, in which
> U-boot sets the right pinfunc for the SD pins.
>
>   pinconfig   100  [ + ]   pinconfig             |   |-- sdmmc
>   pinconfig   101  [ + ]   pinconfig             |   |   |-- sdmmc-bus4
>   pinconfig   102  [ + ]   pinconfig             |   |   |-- sdmmc-clk
>   pinconfig   103  [ + ]   pinconfig             |   |   |-- sdmmc-cmd
>   pinconfig   104  [ + ]   pinconfig             |   |   `-- sdmmc-det
> ...
>   pinconfig   132  [ + ]   pinconfig             |   |-- uart2
>   pinconfig   133  [ + ]   pinconfig             |   |   `-- uart2m0-xfer
>
> => gpio toggle A15
> gpio: pin A15 (gpio 15) value is 1

Look good to me, thanks.

Jagan.