[PATCH] image: Fix potentially uninitialized data variable
marek.vasut at mailbox.org
Thu Mar 2 04:18:14 CET 2023
On 3/1/23 17:02, Tom Rini wrote:
> On Mon, Feb 27, 2023 at 08:56:31PM +0100, Marek Vasut wrote:
>> In case fitImage support is disabled, and image_locate_script() is
>> passed a fitImage, then the 'data' variable is used uninitialized.
>> Drop into the default: branch of the switch-case statement and do
>> not return the uninitialized data, and do not modify the return
>> pointer either, just print an error message.
>> Reported by clang build:
>> $ make HOSTCC=clang CC=clang KCFLAGS=-Werror sandbox64_defconfig && make HOSTCC=clang CC=clang KCFLAGS=-Werror
>> boot/image-board.c:1006:7: error: variable 'data' is used uninitialized whenever switch case is taken [-Werror,-Wsometimes-uninitialized]
>> case IMAGE_FORMAT_LEGACY:
>> include/image.h:608:29: note: expanded from macro 'IMAGE_FORMAT_LEGACY'
>> boot/image-board.c:1128:19: note: uninitialized use occurs here
>> *datap = (char *)data;
>> boot/image-board.c:1001:11: note: initialize the variable 'data' to silence this warning
>> u32 *data;
>> = NULL
>> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
> Reviewed-by: Tom Rini <trini at konsulko.com>
> And can you please do a follow-up that adds sandbox64 + clang, after the
> sandbox + clang test in GitLab/Azure?
The CI is chewing on it here:
More information about the U-Boot