[PATCH 2/2] serial: sh: Add HSCIF support for R-Car SoC

[Marek Vasut]

On 3/1/23 16:01, Simon Glass wrote:
> On Tue, 28 Feb 2023 at 14:29, Marek Vasut
> <marek.vasut+renesas at mailbox.org> wrote:
>>
>> From: Hai Pham <hai.pham.ud at renesas.com>
>>
>> Provide the basic HSCIF support for R-Car SoC.
>>
>> Reviewed-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
>> Signed-off-by: Hai Pham <hai.pham.ud at renesas.com>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
>> [Marek: Fill in HSSRR offset for Gen2 and SCBRR calculation for Gen2 and Gen3]
>> ---
>> Cc: Simon Glass <sjg at chromium.org>
>> ---
>>   doc/device-tree-bindings/serial/sh.txt |  2 +-
>>   drivers/serial/serial_sh.c             |  6 ++++++
>>   drivers/serial/serial_sh.h             | 26 ++++++++++++++++++++++----
>>   include/dm/platform_data/serial_sh.h   |  1 +
>>   4 files changed, 30 insertions(+), 5 deletions(-)
>>
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> but it should really not be looking at CONFIG options in the driver

No, it shouldn't, but untangling that macro mess in serial_sh.h is for 
another day. This one CFG_ is just the tip of a very large and very 
lethal iceberg.