[PATCH 07/10] efi: Add another tranch of GUIDs

[Ilias Apalodimas]

Hi Simon,

On Thu, 2 Mar 2023 at 01:38, Simon Glass <sjg at chromium.org> wrote:
>
> Hi Ilias,
>
> On Wed, 1 Mar 2023 at 01:52, Ilias Apalodimas
> <ilias.apalodimas at linaro.org> wrote:
> >
> > Hi Simon
> >
> > On Sun, 26 Feb 2023 at 03:33, Simon Glass <sjg at chromium.org> wrote:
> > >
> > > Provide information about the GUIDs supplied by QEMU, so far as it is
> > > known.
> >
> > What the patch does is obvious.  Can you explain why this is needed though?
>
> Yes. It allows seeing what the tables actually are, since the GUIDs
> are impenetrable for that. See for example the 'efi table' command in
> this series.
>
> I think %sU uses it too.

Yes, but please put that in the commit message in the next version.

[...]

> > > +       EFI_GUID(0x4c19049f, 0x4137, 0x4dd3, 0x9c, 0x10, \
> > > +                0x8b, 0x97, 0xa8, 0x3f, 0xfd, 0xfa)
> > > +#define EFI_SMBIOS \
> > > +       EFI_GUID(0xeb9d2d31, 0x2d88, 0x11d3, 0x9a, 0x16,  \
> > > +                0x00, 0x90, 0x27, 0x3f, 0xc1, 0x4d)
> >
> > This already exists as SMBIOS_TABLE_GUID
>
> Oh dear, OK. Would you mind if I rename it? It is hard to find things
> if the naming is inconsistent.

I think the naming is already quite consistent here. We are trying to
follow what's in the EFI specification, so it's easy to search and
find things in there (§4.6.1.1 Industry Standard Configuration
Tables).  I'd rather leave it as is

>
> >
> > > +#define EFI_MEM_STATUS_CODE_REC \
> > > +       EFI_GUID(0x060cc026, 0x4c0d, 0x4dda, 0x8f, 0x41, \
> > > +                0x59, 0x5f, 0xef, 0x00, 0xa5, 0x02)
> > > +#define EFI_GUID_SNBIOS \
> > > +       EFI_GUID(0xeb9d2d31, 0x2d88, 0x11d3, 0x9a, 0x16, \
> > > +                0x00, 0x90, 0x27, 0x3f, 0xc1, 0x4d)
> >
> > what is SNBIOS? I assume it's a typos since it matches the existing
> > SMBIOS_TABLE_GUID?
>
> Yes, a typo
>
> >
> > > +#define EFI_GUID_EFI_ACPI1 \
> > > +       EFI_GUID(0xeb9d2d30, 0x2d88, 0x11d3,  0x9a, 0x16, \
> > > +                0x00, 0x90, 0x27, 0x3f, 0xc1, 0x4d)
> > > +#define EFI_GUID_EFI_ACPI2 \
> > > +       EFI_GUID(0x8868e871, 0xe4f1, 0x11d3, 0xbc, 0x22, \
> > > +                0x00, 0x80, 0xc7, 0x3c, 0x88, 0x81)
> >
> > Already exists as EFI_ACPI_TABLE_GUID
>
> OK, bind if I rename it so we have these consistent?

The same thing applies to this one, it's described as-is in the EFI spec.

[...]

Thanks
/Ilias