[PATCH v2 2/8] rockchip: Disable DISTRO_DEFAULTS for rk3399 boards

Tom Rini trini at konsulko.com
Thu Mar 2 16:22:53 CET 2023

On Wed, Mar 01, 2023 at 08:39:23PM -0700, Simon Glass wrote:
> These board have moved to standard boot but the old 'distro_bootcmd'
> command is still active. Disable DISTRO_DEFAULTS to fix this.
> Signed-off-by: Simon Glass <sjg at chromium.org>
> Tested-by: Vagrant Cascadian <vagrant at debian.org>
> ---
> (no changes since v1)
>  arch/arm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index bd7fffcce0b..4e7ebeaee87 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1955,7 +1955,7 @@ config ARCH_ROCKCHIP
>  	imply ADC
>  	imply CMD_DM
>  	imply FAT_WRITE
>  	imply SPL_SYSRESET

This is just opening the door to the next conversion failing for the
same reason I think. We need a new Kconfig symbol, DISTRO_BOOTCMD which
is askable and default y depends on DISTRO_DEFAULTS. Then you can do
imply/select logic for the conversion based on if they have
DISTRO_BOOTCMD or BOOTSTD_BOOTCOMMAND. Because part of the problem here
is that we don't have an option for distro_bootcmd itself, so we need
one. That's in essence the second half of the patch you did which moves
"this is functionality really everyone should enable, for a good general
user experience" out of DISTRO_DEFAULTS&&BOOTSTD_DEFAULTS and in to its
own symbol.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230302/44a9581e/attachment.sig>

More information about the U-Boot mailing list