[PATCH] sysinfo: gpio: fix loop over DT "revisions" array

Simon Glass sjg at chromium.org
Fri Mar 10 21:49:34 CET 2023

On Fri, 10 Mar 2023 at 02:58, Rasmus Villemoes
<rasmus.villemoes at prevas.dk> wrote:
> There can certainly be a lot more elements in the "revisions" (and
> "names") arrays than there are gpios used to form the trinary number
> we're searching for; we simply don't know the array size up-front.
> Nor do we need to, because the loop body already knows to recognize
> -EOVERFLOW as "not that many elements present" (and we have a test
> that specifically ensures that dev_read_u32_index() returns exactly
> that). So just drop the i < priv->gpio_num condition.
> While in here, fix the weird placement of the default: keyword.
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
> ---
>  drivers/sysinfo/gpio.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

More information about the U-Boot mailing list