[PATCH v7 11/23] core: remap: fix regmap_init_mem_plat() reg size handeling

Simon Glass sjg at chromium.org
Sat Mar 11 02:37:47 CET 2023


Hi Johan,

On Fri, 10 Mar 2023 at 08:42, Johan Jonker <jbx6244 at gmail.com> wrote:
>
> The fdt_addr_t and phys_addr_t size have been decoupled.
> A 32bit CPU can expect 64-bit data from the device tree parser,

Sorry if you already responded and I missed it.

I don't understand this line. It looks like sizeof(fdt_addr_t) is
still 4 on 32-bit machines. So what does this actually mean?

> so convert regmap_init_mem_plat() input to handel both. The
> syscon class driver also makes use of the regmap_init_mem_plat()
> function, but has no way of knowing the format of the
> device-specific platform data. In case of odd reg structures other
> then that the syscon class driver assumes the regmap must be
> filled in the individual syscon driver before pre-probe.
> Also fix the ARRAY_SIZE divider in the syscon class driver.


Regards,
Simon

> Signed-off-by: Johan Jonker <jbx6244 at gmail.com>
> ---
>
> Changed V7:
>   changed title
>   add reg size input
>   rework function calls
> ---
>  drivers/core/regmap.c               | 23 +++++++++++++++++++----
>  drivers/core/syscon-uclass.c        | 21 ++++++++++++++++-----
>  drivers/ram/rockchip/sdram_rk3066.c |  2 +-
>  drivers/ram/rockchip/sdram_rk3188.c |  2 +-
>  drivers/ram/rockchip/sdram_rk322x.c |  2 +-
>  drivers/ram/rockchip/sdram_rk3288.c |  2 +-
>  drivers/ram/rockchip/sdram_rk3328.c |  2 +-
>  drivers/ram/rockchip/sdram_rk3399.c |  2 +-
>  include/regmap.h                    |  5 +++--
>  include/syscon.h                    | 13 -------------
>  10 files changed, 44 insertions(+), 30 deletions(-)
>

[..]


More information about the U-Boot mailing list