[PATCH v2 1/2] x86: Revert "x86: minnowmax: Adjust CONFIG_TEXT_BASE"

Bin Meng bmeng.cn at gmail.com
Mon Mar 13 10:47:57 CET 2023


Hi Simon,

On Sat, Mar 11, 2023 at 7:33 AM Simon Glass <sjg at chromium.org> wrote:
>
> This causes Minnowmax to stop booting. Revert it so we have a good
> example of how to do this fully.
>
> This reverts commit 66e2c665f3b60d726e1c26ad44ac97aa76ead6f5.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> (no changes since v1)
>
>  configs/minnowmax_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig
> index 679b6e3de53..b3b15d86e17 100644
> --- a/configs/minnowmax_defconfig
> +++ b/configs/minnowmax_defconfig
> @@ -1,5 +1,5 @@
>  CONFIG_X86=y
> -CONFIG_TEXT_BASE=0xFFE00000
> +CONFIG_TEXT_BASE=0xFFF00000
>  CONFIG_NR_DRAM_BANKS=8
>  CONFIG_ENV_SIZE=0x1000
>  CONFIG_ENV_OFFSET=0x6EF000
> --
> 2.40.0.rc1.284.g88254d51c5-goog
>

Instead of reverting commits, could you do directly fix instead, using
a "Fixes: <commit sha> ("")" format?

Also there should be the following commits that should be fixed on
other BayTrail boards.

f38be3086837e3637fe588f6571c2d245261e5fb: x86: bayleybay: Adjust
CONFIG_TEXT_BASE
388f93f963546b49821e0142628f70203bc99c18: x86:
conga-qeval20-qa3-e3845: Adjust CONFIG_TEXT_BASE
5d1c8342aeaaa13a32e86571ec054ed3582c0d67: x86: dfi-bt700: Adjust
CONFIG_TEXT_BASE
e23cae30801fab679e98029e0d3079592e1d3915: x86: som-db5800-som-6867:
Adjust CONFIG_TEXT_BASE

Regards,
Bin


More information about the U-Boot mailing list