[PATCH v3 00/23] CONFIG_IS_ENABLED vs IS_ENABLED
Troy Kisky
troykiskyboundary at gmail.com
Mon Mar 13 22:31:22 CET 2023
This patch set gets ready to checks the usage of
CONFIG_IS_ENABLED/IS_ENABLED.
After the set has been applied, you can delete
test/usage_of_is_enabled_todo.txt
and run test/usage_of_is_enabled_commit.sh
The script test/usage_of_is_enabled_check.sh
checks for new questionable uses of
CONFIG_IS_ENABLED/IS_ENABLED and is added
to .azure-pipelines.yml, and
.gitlab-ci.yml
version 3 changes:
Dropped changes to puma-rk3399 and ringneck-px30
in favor of Quentin Schulz's patch
https://patchwork.ozlabs.org/project/uboot/patch/20230301-tsd-env-nowhere-kconfig-v1-1-d5c08e096906@theobroma-systems.com/
https://patchwork.ozlabs.org/project/uboot/patch/20230301-tsd-env-nowhere-kconfig-v1-2-d5c08e096906@theobroma-systems.com/
Please apply them before this series.
Drop gateworks: venice: Always define setup_fec and setup_eqos
Drop arm: cpu: armv7: ls102xa: fdt: remove eth_device support
Simon's patches took care of these
Add to todo list, these new questionable uses that snuck into the code.
PARTITION_TYPE_GUID
PHY_ATHEROS
RTC_SANDBOX
Changes in v3:
remove error entirely and prevent with Kconfig
new patch to address Tom's concerns
- Rebase on Simon's s/CMD_SATA/SATA/ change
- commit message updated
Changes in v2:
- new patch
- delay include of linux/kconfig.h to do from Makefile
- as suggested by Simon
- delay include of linux/kconfig.h to do from Makefile
- as suggested by Simon
- delay include of linux/kconfig.h to do from Makefile
- as suggested by Simon
- delay include of linux/kconfig.h to do from Makefile
- as suggested by Simon
- delay include of linux/kconfig.h to do from Makefile
- as suggested by Simon
- include linux/kconfig.h from tools/Makefile
- as suggested by Simon
- changed condition of when to include field bdf
- added protection to another instance of bdf in uart.c
- Thanks to Simon for getting this corrected
- use normal if, not preprocessor
- new in series
- use an accessor function gd_set_pci_ram_top
Troy Kisky (23):
kconfig: add IS_ENABLED_NOCHECK to bypass usage_of_is_enabled_check
cmd: nvedit: remove error check, handle with Kconfig
lib: crc32: prepare for CONFIG_IS_ENABLED changes
lib: md5: prepare for CONFIG_IS_ENABLED changes
lib: sha1: prepare for CONFIG_IS_ENABLED changes
lib: sha256: prepare for CONFIG_IS_ENABLED changes
lib: sha512: prepare for CONFIG_IS_ENABLED changes
watchdog: add and use Kconfig HAS_WATCHDOG_RUNNING
tools: prevent CONFIG_IS_ENABLED errors by including linux/kconfig.h
tools: Makefile: prepare for CONFIG_IS_ENABLED changes by adding
CONFIG_TOOLS_xxx
x86: cpu: qemu: qemu: remove SPL use with CONFIG_IS_ENABLED
config_distro_bootcmd: remove booting environment variables from SPL
environment
ofnode: fdt_support definitions needed if OF_CONTROL is enabled
fdt_support: always define fdt_fixup_mtdparts
m53menlo: define ft_board_setup only if CONFIG_IS_ENABLED(OF_LIBFDT)
freescale: common: pfuze: define pfuze_mode_init only if
defined(CONFIG_DM_PMIC)
ns16550: match when to define bdf with uart code
solidrun: mx6cuboxi: use CONFIG_IS_ENABLED(SATA) instead of ifdef
CONFIG_SATA
wandboard: use CONFIG_IS_ENABLED(SATA) instead of ifdef CONFIG_SATA
arm: mach-imx: use CONFIG_$(SPL_)SATA instead of CONFIG_SATA
x86: cpu: i386: cpu: only set pci_ram_top if CONFIG_IS_ENABLED(PCI)
power: pmic: add dm style definitions if not
CONFIG_IS_ENABLED(POWER_LEGACY)
CI: add test/usage_of_is_enabled_check.sh
.azure-pipelines.yml | 11 ++
.gitlab-ci.yml | 5 +
arch/arm/mach-imx/Makefile | 2 +-
arch/arm/mach-omap2/boot-common.c | 5 +-
arch/m68k/lib/time.c | 7 +-
arch/powerpc/lib/interrupts.c | 5 +-
arch/powerpc/lib/ticks.S | 2 +-
arch/x86/cpu/apollolake/uart.c | 4 +
arch/x86/cpu/i386/cpu.c | 2 +-
arch/x86/cpu/qemu/qemu.c | 2 +-
board/astro/mcf5373l/fpga.c | 10 +-
board/freescale/common/pfuze.c | 2 +-
board/menlo/m53menlo/m53menlo.c | 2 +
board/solidrun/mx6cuboxi/mx6cuboxi.c | 5 +-
board/wandboard/wandboard.c | 5 +-
boot/image-board.c | 2 +-
cmd/nvedit.c | 32 +---
cmd/ximg.c | 10 +-
common/board_f.c | 4 +-
common/spl/Kconfig | 4 +
drivers/crypto/aspeed/aspeed_hace.c | 2 +-
drivers/crypto/hash/hash_sw.c | 2 +-
drivers/timer/mpc83xx_timer.c | 5 +-
drivers/watchdog/Kconfig | 3 +
env/Kconfig | 17 ++-
fs/cramfs/uncompress.c | 9 +-
include/asm-generic/global_data.h | 6 +
include/config_distro_bootcmd.h | 23 +++
include/fdt_support.h | 26 ++--
include/linux/kconfig.h | 5 +
include/ns16550.h | 2 +-
include/power/pmic.h | 2 +-
include/watchdog.h | 7 +-
lib/bzip2/bzlib.c | 5 +-
lib/bzip2/bzlib_decompress.c | 20 +--
lib/crc32.c | 11 +-
lib/md5.c | 7 +-
lib/sha1.c | 7 +-
lib/sha256.c | 7 +-
lib/sha512.c | 11 +-
test/usage_of_is_enabled_check.sh | 19 +++
test/usage_of_is_enabled_commit.sh | 12 ++
test/usage_of_is_enabled_correct.sh | 50 +++++++
test/usage_of_is_enabled_exempt.txt | 9 ++
test/usage_of_is_enabled_list.sh | 86 +++++++++++
test/usage_of_is_enabled_splcfg.txt | 21 +++
test/usage_of_is_enabled_todo.txt | 213 +++++++++++++++++++++++++++
tools/Makefile | 3 +
48 files changed, 584 insertions(+), 127 deletions(-)
create mode 100755 test/usage_of_is_enabled_check.sh
create mode 100755 test/usage_of_is_enabled_commit.sh
create mode 100755 test/usage_of_is_enabled_correct.sh
create mode 100644 test/usage_of_is_enabled_exempt.txt
create mode 100755 test/usage_of_is_enabled_list.sh
create mode 100644 test/usage_of_is_enabled_splcfg.txt
create mode 100644 test/usage_of_is_enabled_todo.txt
--
2.34.1
More information about the U-Boot
mailing list