[PATCH 10/12] rockchip: include: configs: Remove dangling comments

Kever Yang kever.yang at rock-chips.com
Tue Mar 14 04:28:33 CET 2023


On 2023/3/14 08:38, Jonas Karlman wrote:
> This removes dangling comments that no longer serve a purpose and has
> been left after conversion of defines to Kconfig option.
>
> Signed-off-by: Jonas Karlman <jonas at kwiboo.se>
Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>   include/configs/rk3128_common.h   | 4 ----
>   include/configs/rk3188_common.h   | 5 -----
>   include/configs/rk3288_common.h   | 2 --
>   include/configs/rk3328_common.h   | 1 -
>   include/configs/rk3399_common.h   | 1 -
>   include/configs/rockchip-common.h | 2 --
>   include/configs/rv1108_common.h   | 2 --
>   include/configs/vyasa-rk3288.h    | 6 ------
>   8 files changed, 23 deletions(-)
>
> diff --git a/include/configs/rk3128_common.h b/include/configs/rk3128_common.h
> index 8aa17bfbd364..8736b14d1015 100644
> --- a/include/configs/rk3128_common.h
> +++ b/include/configs/rk3128_common.h
> @@ -12,13 +12,9 @@
>   
>   #define CFG_IRAM_BASE		0x10080000
>   
> -/* RAW SD card / eMMC locations. */
> -
>   #define CFG_SYS_SDRAM_BASE		0x60000000
>   #define SDRAM_MAX_SIZE			0x80000000
>   
> -/* usb mass storage */
> -
>   #define ENV_MEM_LAYOUT_SETTINGS \
>   	"scriptaddr=0x60500000\0" \
>   	"pxefile_addr_r=0x60600000\0" \
> diff --git a/include/configs/rk3188_common.h b/include/configs/rk3188_common.h
> index ac9195672fb7..ebb421c69297 100644
> --- a/include/configs/rk3188_common.h
> +++ b/include/configs/rk3188_common.h
> @@ -11,15 +11,10 @@
>   
>   #define CFG_IRAM_BASE	0x10080000
>   
> -/* spl size 32kb sram - 2kb bootrom */
> -
>   #define CFG_SYS_SDRAM_BASE		0x60000000
>   #define SDRAM_BANK_SIZE			(2UL << 30)
>   #define SDRAM_MAX_SIZE			0x80000000
>   
> -/* usb otg */
> -
> -/* usb host support */
>   #define ENV_MEM_LAYOUT_SETTINGS \
>   	"scriptaddr=0x60000000\0" \
>   	"pxefile_addr_r=0x60100000\0" \
> diff --git a/include/configs/rk3288_common.h b/include/configs/rk3288_common.h
> index 5f29432be10b..fa409c70c931 100644
> --- a/include/configs/rk3288_common.h
> +++ b/include/configs/rk3288_common.h
> @@ -13,8 +13,6 @@
>   
>   #define CFG_IRAM_BASE		0xff700000
>   
> -/* RAW SD card / eMMC locations. */
> -
>   #define CFG_SYS_SDRAM_BASE		0
>   #define SDRAM_BANK_SIZE			(2UL << 30)
>   #define SDRAM_MAX_SIZE			0xfe000000
> diff --git a/include/configs/rk3328_common.h b/include/configs/rk3328_common.h
> index 24b21c024dee..e565ccff8979 100644
> --- a/include/configs/rk3328_common.h
> +++ b/include/configs/rk3328_common.h
> @@ -10,7 +10,6 @@
>   
>   #define CFG_IRAM_BASE		0xff090000
>   
> -/* FAT sd card locations. */
>   #define CFG_SYS_SDRAM_BASE		0
>   #define SDRAM_MAX_SIZE			0xff000000
>   
> diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h
> index 3ef9ffa2e9c4..04dcbf20bcb5 100644
> --- a/include/configs/rk3399_common.h
> +++ b/include/configs/rk3399_common.h
> @@ -10,7 +10,6 @@
>   
>   #define CFG_IRAM_BASE		0xff8c0000
>   
> -/* FAT sd card locations. */
>   #define CFG_SYS_SDRAM_BASE		0
>   #define SDRAM_MAX_SIZE			0xf8000000
>   
> diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
> index b7c5c6634394..18544d75acc6 100644
> --- a/include/configs/rockchip-common.h
> +++ b/include/configs/rockchip-common.h
> @@ -11,8 +11,6 @@
>   #define CFG_CPUID_OFFSET	0x7
>   #endif
>   
> -/* ((CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR - 64) * 512) */
> -
>   #ifndef CONFIG_SPL_BUILD
>   
>   /* First try to boot from SD (index 1), then eMMC (index 0) */
> diff --git a/include/configs/rv1108_common.h b/include/configs/rv1108_common.h
> index 63551b47e200..050d37bff0b5 100644
> --- a/include/configs/rv1108_common.h
> +++ b/include/configs/rv1108_common.h
> @@ -17,8 +17,6 @@
>   
>   #define CFG_SYS_SDRAM_BASE		0x60000000
>   
> -/* rockchip ohci host driver */
> -
>   #define ENV_MEM_LAYOUT_SETTINGS \
>   	"scriptaddr=0x60000000\0" \
>   	"fdt_addr_r=0x61f00000\0" \
> diff --git a/include/configs/vyasa-rk3288.h b/include/configs/vyasa-rk3288.h
> index e8c1013a71a3..81ff61bf7a6a 100644
> --- a/include/configs/vyasa-rk3288.h
> +++ b/include/configs/vyasa-rk3288.h
> @@ -20,10 +20,4 @@
>   #define BOOT_TARGET_DEVICES(func) \
>   	func(MMC, mmc, 1) \
>   
> -#ifndef CONFIG_TPL_BUILD
> -/* Falcon Mode */
> -
> -/* Falcon Mode - MMC support: args at 16MB kernel at 17MB */
> -#endif
> -
>   #endif


More information about the U-Boot mailing list