[PATCH v1 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider

[Simon Glass]

Hi Johan,

On Thu, 16 Mar 2023 at 10:46, Johan Jonker <jbx6244 at gmail.com> wrote:
>
> The current divider to calculate the bank ID can change.
> Use a constant ROCKCHIP_GPIOS_PER_BANK as fixed divider.

What is the motivation for this patch?

>
> Signed-off-by: Johan Jonker <jbx6244 at gmail.com>
> ---
>  drivers/gpio/rk_gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

>
> diff --git a/drivers/gpio/rk_gpio.c b/drivers/gpio/rk_gpio.c
> index f7ad4d68..0a2acf18 100644
> --- a/drivers/gpio/rk_gpio.c
> +++ b/drivers/gpio/rk_gpio.c
> @@ -160,7 +160,7 @@ static int rockchip_gpio_probe(struct udevice *dev)
>                                              0, &args);
>         if (!ret || ret != -ENOENT) {
>                 uc_priv->gpio_count = args.args[2];
> -               priv->bank = args.args[1] / args.args[2];
> +               priv->bank = args.args[1] / ROCKCHIP_GPIOS_PER_BANK;
>         } else {
>                 uc_priv->gpio_count = ROCKCHIP_GPIOS_PER_BANK;
>                 end = strrchr(dev->name, '@');
> --
> 2.20.1
>

Regards,
SImon