[PATCH 1/4] phy: Add empty generic_phy_configure() implementation for PHY disabled case

Patrice CHOTARD patrice.chotard at foss.st.com
Mon Mar 20 09:23:16 CET 2023


Hi Marek

On 3/19/23 18:09, Marek Vasut wrote:
> In case PHY is not enabled, the generic_phy_configure() implementation is
> missing. Add an empty one so that the list of empty functions is complete.
> 
> Fixes: f8da8a82c57 ("generic-phy: add configure op")
> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
> ---
> Cc: Jim Liu <jim.t90615 at gmail.com>
> Cc: Neil Armstrong <neil.armstrong at linaro.org>
> Cc: Patrice Chotard <patrice.chotard at foss.st.com>
> Cc: Samuel Holland <samuel at sholland.org>
> Cc: Sumit Garg <sumit.garg at linaro.org>
> Cc: Weijie Gao <weijie.gao at mediatek.com>
> ---
>  include/generic-phy.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/generic-phy.h b/include/generic-phy.h
> index f8eddeff67a..fa5f6fa3636 100644
> --- a/include/generic-phy.h
> +++ b/include/generic-phy.h
> @@ -389,6 +389,11 @@ static inline int generic_phy_power_off(struct phy *phy)
>  	return 0;
>  }
>  
> +static inline int generic_phy_configure(struct phy *phy, void *params)
> +{
> +	return 0;
> +}
> +
>  static inline int generic_phy_get_by_index(struct udevice *user, int index,
>  			     struct phy *phy)
>  {

Reviewed-by: Patrice Chotard <patrice.chotard at foss.st.com>

Thanks
Patrice


More information about the U-Boot mailing list