[PATCH v2 1/2] rockchip: efuse: fix misc_read() return values

Simon Glass sjg at chromium.org
Mon Mar 20 19:39:58 CET 2023


On Tue, 21 Mar 2023 at 06:18, John Keeping <john at metanate.com> wrote:
>
> The documentation for misc_read() says:
>
>     Return: number of bytes read if OK (may be 0 if EOF), -ve on error
>
> The Rockchip efuse driver implements this so it should return the number
> of bytes read rather than zero on success.  Fix this so that the driver
> follows the usual contract for read operations.
>
> Signed-off-by: John Keeping <john at metanate.com>
> ---
> v2:
> - Fix when block_size > 1 by moving the return value to the main
>   rockchip_efuse_read() wrapper and leaving the individual
>   implementations alone (Jonas)
>
>  drivers/misc/rockchip-efuse.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list