[PATCH 03/13] input: Only reset the keyboard when running bare metal

Simon Glass sjg at chromium.org
Mon Mar 20 19:40:03 CET 2023


Hi Bin,

On Mon, 20 Mar 2023 at 19:32, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Simon,
>
> On Tue, Feb 21, 2023 at 3:49 AM Simon Glass <sjg at chromium.org> wrote:
> >
> > If U-Boot is not the first-stage bootloader we should not init the
> > keyboard, since it has already been done. Check for this.
>
> But re-init does no harm, right?

Actually it causes the keyboard to fail on Brya (Felwinter), a
Chromebook. It could be due to it having a numeric keypad.

>
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> >  drivers/input/i8042.c | 13 +++++++++----
> >  1 file changed, 9 insertions(+), 4 deletions(-)
> >

Regards,
Simon


More information about the U-Boot mailing list