[PATCH v2 03/10] arm: K3: Add basic support for J784S4 SoC definition

[Tom Rini]

On Tue, Mar 21, 2023 at 09:10:21AM -0500, Hari Nagalla wrote:

Please include at least the usual one line summary here.

[snip]
> diff --git a/include/configs/j784s4_evm.h b/include/configs/j784s4_evm.h
> new file mode 100644
> index 0000000000..3e429fb036
> --- /dev/null
> +++ b/include/configs/j784s4_evm.h
> @@ -0,0 +1,49 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * Configuration header file for K3 J784S4 EVM
> + *
> + * Copyright (C) 2022 Texas Instruments Incorporated - https://www.ti.com/
> + *	Hari Nagalla <hnagalla at ti.com>
> + */
> +
> +#ifndef __CONFIG_J784S4_EVM_H
> +#define __CONFIG_J784S4_EVM_H
> +
> +#include <linux/sizes.h>
> +#include <config_distro_bootcmd.h>
> +#include <environment/ti/mmc.h>
> +
> +/* DDR Configuration */
> +#define CFG_SYS_SDRAM_BASE1		0x880000000
> +
> +#ifdef CONFIG_CMD_MMC
> +#define DISTRO_BOOT_DEV_MMC(func) func(MMC, mmc, 0) func(MMC, mmc, 1)
> +#else
> +#define DISTRO_BOOT_DEV_MMC(func)
> +#endif
> +
> +#ifdef CONFIG_CMD_PXE
> +#define DISTRO_BOOT_DEV_PXE(func) func(PXE, pxe, na)
> +#else
> +#define DISTRO_BOOT_DEV_PXE(func)
> +#endif
> +
> +#ifdef CONFIG_CMD_DHCP
> +#define DISTRO_BOOT_DEV_DHCP(func) func(DHCP, dhcp, na)
> +#else
> +#define DISTRO_BOOT_DEV_DHCP(func)
> +#endif
> +
> +#define BOOT_TARGET_DEVICES(func) \
> +	DISTRO_BOOT_DEV_MMC(func) \
> +	DISTRO_BOOT_DEV_PXE(func) \
> +	DISTRO_BOOT_DEV_DHCP(func)

I think you should look at using BOOTSTD here, to start with, rather
than the distro_bootcmd macros. Converting the rest of K3 to use this as
well can be a later task.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230321/4224accf/attachment.sig>