[PATCH] dma: ti: k3-udma: Fix channel hang on teardown

Tom Rini trini at konsulko.com
Wed Mar 22 19:03:16 CET 2023


On Wed, Mar 08, 2023 at 09:42:57AM +0530, Vignesh Raghavendra wrote:

> Setting RX flow error handling will stall the channel until descriptors
> are available to move RX data. Setting this bit causes issues when
> tearing down ethernet DMA channel at the end of TFTP transfer as
> unrelated network packets can cause teardown to stall indefinitely waiting
> for driver to queue add more desc leading to channel hang with error
> logs:
> udma_stop_dev2mem TIMEOUT !
> udma_stop_dev2mem: peer not stopped TIMEOUT !
> udma_stop_dev2mem TIMEOUT !
> 
> Fix this by clearing rx_error_handling similar to how its done for UDMA
> as part of udma_alloc_rchan_sci_req()
> 
> This fixes occasional TFTP Failures seen when downloading multiple files
> one after the other on AM64/AM62 SoCs.
> 
> Fixes: 9a92851c33e8 ("dma: ti: k3-udma: Add BCDMA and PKTDMA support")
> Reported-by: Nishanth Menon <nm at ti.com>
> Signed-off-by: Vignesh Raghavendra <vigneshr at ti.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230322/5808bc78/attachment.sig>


More information about the U-Boot mailing list