[PATCH v2 2/2] rockchip: otp: fix misc_read() return values

Jonas Karlman jonas at kwiboo.se
Sun Mar 26 20:57:40 CEST 2023


Hi John,

On 2023-03-20 19:39, Simon Glass wrote:
> On Tue, 21 Mar 2023 at 06:18, John Keeping <john at metanate.com> wrote:
>>
>> The documentation for misc_read() says:
>>
>>     Return: number of bytes read if OK (may be 0 if EOF), -ve on error
>>
>> The Rockchip efuse driver implements this so it should return the number
>> of bytes read rather than zero on success.  Fix this so that the driver
>> follows the usual contract for read operations.
>>
>> Signed-off-by: John Keeping <john at metanate.com>
>> ---
>> v2:
>> - New patch
>>
>>  drivers/misc/rockchip-otp.c | 12 ++++++++----
>>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>

Reviewed-by: Jonas Karlman <jonas at kwiboo.se>

Regards,
Jonas


More information about the U-Boot mailing list