[PATCH v2 9/9] arm: Migrate Apple M1 to save_prev_bl_data

Mark Kettenis mark.kettenis at xs4all.nl
Mon Mar 27 21:19:54 CEST 2023


> From: Simon Glass <sjg at chromium.org>
> Date: Tue, 28 Mar 2023 08:02:24 +1300
> 
> Hi,
> 
> On Mon, 27 Mar 2023 at 23:47, Konrad Dybcio <konrad.dybcio at linaro.org> wrote:
> >
> > Mark's and Dzmitry's approaches come down to the same thing.. Let's
> > unify them by first removing the static keyword from the common file
> > to allow the variable to be reused, then renaming "reg0" to the more
> > sensible fw_dtb_pointer coming from the Apple file and finally remove
> > the mach-apple implementation of this very thing and enable the common
> > approach in the respective defconfig.
> >
> > Only build-tested.
> >
> > Signed-off-by: Konrad Dybcio <konrad.dybcio at linaro.org>
> > ---
> >  arch/arm/lib/save_prev_bl_data.c    | 14 +++++++-------
> >  arch/arm/mach-apple/Makefile        |  1 -
> >  arch/arm/mach-apple/lowlevel_init.S | 17 -----------------
> >  configs/apple_m1_defconfig          |  1 +
> >  4 files changed, 8 insertions(+), 25 deletions(-)
> 
> Perhaps we could start using a bloblist (in preparation for the coming
> Firmware Handoff [1] [2]) to pass information between stages?

We don't have TPL or SPL on these machines, only U-Boot proper.  And
the handoff protocol between m1n1 and U-Boot is defined by [3].  I
have zero interest in changing that and my guess is that Hector Martin
feels the same.

Cheers,

Mark

[3] https://docs.kernel.org/arm64/booting.html


More information about the U-Boot mailing list