[PATCH v5 00/17] Basic StarFive JH7110 RISC-V SoC support

yanhong wang yanhong.wang at starfivetech.com
Wed Mar 29 12:16:20 CEST 2023



On 2023/3/29 17:41, Torsten Duwe wrote:
> On Wed, 29 Mar 2023 11:42:07 +0800
> Yanhong Wang <yanhong.wang at starfivetech.com> wrote:
> 
>> v5:
> [...]
>> - Splitted starfive_visionfive2_defconfig into starfive_visionfive2_12a_defconfig
>>   and starfive_visionfive2_13b_defconfig.
> 
> Is this really necessary? It puts another burden on people building U-Boot,
> distribution networks, and last but not least users, who will need to pick the
> correct binary blob, after trying to find out which board they actually have.
> 
> Even past versions can detect the installed RAM correctly and will modify
> the DT accordingly, I assume? Why not make an inquiry on GMAC1_MDIO to tell
> whether it's a YT8512C (->v1.2A) or another YT8531C (->v1.3B), in the ethernet
> patch set, and likewise update the device tree dynamically then?
> 

There is only one defconfig in V4, and dts is separate for versions 1.2a and 1.3b.
Andreas Schwab suggested that defconfig is also defined separately, so the definition 
of defconfig in V5 is also separated. 

The discussion process  as follows:

https://patchwork.ozlabs.org/project/uboot/patch/20230316025332.3297-18-yanhong.wang@starfivetech.com/

Do you have any better suggestion on whether defconfig is defined separately?

> 	Torsten


More information about the U-Boot mailing list