[PATCH v4 06/15] common: Makefile: Add rule to compile splash and splash_source at SPL

[Devarsh Thakkar]

Hi Nikhil,

Thanks for the patch.

On 29/03/23 17:31, Nikhil M Jain wrote:
> To enable splash screen and loading bmp from boot media, add rules to
> compile splash.c and splash_source.c at SPL stage only when
> CONFIG_SPL_SPLASH_SCREEN and CONFIG_SPL_SPLASH_SOURCE are defined.
> 
> Signed-off-by: Nikhil M Jain <n-jain1 at ti.com>
> ---
> V4:
> - No change
> 
> V3 (patch introduced):
> - Rule to compile splash.c and splash_source.c
> 
>  common/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/common/Makefile b/common/Makefile
> index a50302d8b5..3a6ca337e0 100644
> --- a/common/Makefile
> +++ b/common/Makefile
> @@ -56,6 +56,8 @@ obj-$(CONFIG_$(SPL_TPL_)OF_LIBFDT) += fdt_support.o
>  obj-$(CONFIG_SPL_USB_HOST) += usb.o usb_hub.o
>  obj-$(CONFIG_SPL_USB_STORAGE) += usb_storage.o
>  obj-$(CONFIG_SPL_MUSB_NEW) += usb.o
> +obj-$(CONFIG_SPL_SPLASH_SCREEN) += splash.o
I think above macro is tied to using splashimage env, I think you should use
obj-y for this as done in u-boot proper for not to alter the meaning of macro
for now.
In case separate Kconfig is needed for splash.o than imho it should be fixed
in u-boot proper and parallel Kconfig should be introduced for SPL then.

Regards
Devarsh