[PATCH v10 03/10] lib: uuid: introduce testcase for uuid_str_to_le_bin

Abdellatif El Khlifi abdellatif.elkhlifi at arm.com
Thu Mar 30 12:27:07 CEST 2023


On Thu, Mar 30, 2023 at 09:02:18AM +1300, Simon Glass wrote:
> On Wed, 29 Mar 2023 at 05:12, Abdellatif El Khlifi
> <abdellatif.elkhlifi at arm.com> wrote:
> >
> > provide a test case
> >
> > Signed-off-by: Abdellatif El Khlifi <abdellatif.elkhlifi at arm.com>
> > Cc: Simon Glass <sjg at chromium.org>
> > ---
> >  MAINTAINERS       |  5 +++++
> >  test/lib/Makefile |  1 +
> >  test/lib/uuid.c   | 44 ++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 50 insertions(+)
> >  create mode 100644 test/lib/uuid.c
> 
> Still this is missing a change log. Please can you check your process.

This commit has been introduced in v9 patchset. No change made in the v10.
In v11 I'll add a changelog reflecting the use of ut_asserteq_mem().

> Do you use patman?

No, I'm planning to learn about it.

> 
> Can you use ut_asserteq_mem()? If not, please add a comment as to why
> that doesn't work, so it is clear.

Thanks. It works and will be included in v11.
Could you please provide a feedback for the other commits so I can address
everything in one go in patchset v11 ?

Cheers
Abdellatif

> 
> Regards,
> SImon


More information about the U-Boot mailing list