Missed rename of CONFIG_RAM_RK3399_LPDDR4

David Sebek dasebek at gmail.com
Thu Mar 30 22:43:27 CEST 2023


Correction: The correct condition should be:
#if defined(CONFIG_RAM_ROCKCHIP_LPDDR4)

The constant was renamed from CONFIG_RAM_RK3399_LPDDR4 to
CONFIG_RAM_ROCKCHIP_LPDDR4 in commit 26f92be0. I accidentally copy-pasted
the wrong value in my previous email.

On Thu, Mar 30, 2023 at 4:14 PM Simon Glass <sjg at chromium.org> wrote:

> +Jagan Teki
> +Kever Yang
>
> On Thu, 30 Mar 2023 at 15:26, David Sebek <dasebek at gmail.com> wrote:
> >
> > Hi,
> >
> > I think this line:
> >
> https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/ram/rockchip/sdram_rk3399.c#L2957
> > should be
> >
> > #if defined(CONFIG_RAM_ROCKCHIP_DEBUG)
> > instead of
> > #if defined(CONFIG_RAM_RK3399_LPDDR4)
> >
> > The condition now evaluates to false on the RockPro64 board in the latest
> > U-Boot version, which I believe is incorrect.
> >
> > Thanks,
> > David Sebek
>


More information about the U-Boot mailing list