[PATCH 14/38] qfw: Show the file address if available

[Simon Glass]

Hi Heinrich,

On Fri, 31 Mar 2023 at 11:31, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
>
>
> Am 30. März 2023 23:32:03 MESZ schrieb Simon Glass <sjg at chromium.org>:
> >Some files have an associated address. Show this with the 'qfw list'
> >command so that it is possible to dump the data.
> >
> >Signed-off-by: Simon Glass <sjg at chromium.org>
> >---
> >
> > cmd/qfw.c             |  2 +-
> > doc/usage/cmd/qfw.rst | 28 ++++++++++++++++------------
> > 2 files changed, 17 insertions(+), 13 deletions(-)
> >
> >diff --git a/cmd/qfw.c b/cmd/qfw.c
> >index ae3c6a7a84e9..d6ecfa60d5a7 100644
> >--- a/cmd/qfw.c
> >+++ b/cmd/qfw.c
> >@@ -26,7 +26,7 @@ static int qemu_fwcfg_cmd_list_firmware(void)
> >       for (file = qfw_file_iter_init(qfw_dev, &iter);
> >            !qfw_file_iter_end(&iter);
> >            file = qfw_file_iter_next(&iter)) {
> >-              printf("%-56s\n", file->cfg.name);
> >+              printf("%08lx %-56s\n", file->addr, file->cfg.name);
>
> Are the tables always in the lower 4GiB on all architectures (riscv64, arm64, x86)?

Yes, so far as I have seen on x86. We don't generate them for ARM or
RISC-V. I do want to make sure the addresses are readable.

[..]

Regards,
Simon