[PATCH 18/38] efi: Show all known UUIDs with CONFIG_CMD_EFIDEBUG

Heinrich Schuchardt xypron.glpk at gmx.de
Fri Mar 31 02:27:16 CEST 2023



Am 31. März 2023 01:48:57 MESZ schrieb Simon Glass <sjg at chromium.org>:
>Hi Heinrich,
>
>On Fri, 31 Mar 2023 at 11:38, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>>
>>
>>
>> Am 30. März 2023 23:32:07 MESZ schrieb Simon Glass <sjg at chromium.org>:
>> >The CMD_EFIDEBUG option enables debugging so it is reasonable to assume
>> >that all effects should be made to decode the dreaded UUIDs favoured by
>> >UEFI.
>> >
>> >Update the table to show them all when CONFIG_CMD_EFIDEBUG is enabled.
>> >
>> >Signed-off-by: Simon Glass <sjg at chromium.org>
>> >---
>> >
>> > lib/uuid.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> >diff --git a/lib/uuid.c b/lib/uuid.c
>> >index 96e1af3c8b00..ab30fbf9152f 100644
>> >--- a/lib/uuid.c
>> >+++ b/lib/uuid.c
>> >@@ -255,7 +255,7 @@ static const struct {
>> >               EFI_CERT_TYPE_PKCS7_GUID,
>> >       },
>> > #endif
>> >-#ifdef CONFIG_EFI
>> >+#if defined(CONFIG_CMD_EFIDEBUG) || defined(CONFIG_EFI)
>> >       { "EFI_LZMA_COMPRESSED", EFI_LZMA_COMPRESSED },
>> >       { "EFI_DXE_SERVICES", EFI_DXE_SERVICES },
>> >       { "EFI_HOB_LIST", EFI_HOB_LIST },
>>
>> None of these are used when not building the EFI app.
>
>So you think we should disable them? As I said above, enabling
>debugging seems like a good reason to allow decoding of all of them.
>
>Regards,
>SImon

U-Boot, Shim, GRUB will not use any of these. The EFI app sees them if shared by the preceding UEFI firmware.

There are zillions other GUIDs that a vendor UEFI might use. But why should we care?

I would rather drop these strings from the code base.

Best regards

Heinrich



More information about the U-Boot mailing list