[PATCH 3/6] serial: msm-geni: remove invalid se-clk clock name

Konrad Dybcio konrad.dybcio at linaro.org
Fri Mar 31 03:25:59 CEST 2023



On 30.03.2023 21:47, Vladimir Zapolskiy wrote:
> There is only one clock supplier to the serial IP, thus getting it by
> name is not needed, also note that "clock-names" property is not listed
> under doc/device-tree-bindings/serial/msm-geni-serial.txt, and finally
> "se-clk" clock name is invalid, if added, it shall get "se" value like
> it's already described in Linux device tree documentation.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy at linaro.org>
> ---
OK this is even better than my approach of using "se", didn't know
we could just "get whatever's present".

Reviewed-by: Konrad Dybcio <konrad.dybcio at linaro.org>

Konrad
>  drivers/serial/serial_msm_geni.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/serial/serial_msm_geni.c b/drivers/serial/serial_msm_geni.c
> index df61ae04df0a..1b12fdfbdafc 100644
> --- a/drivers/serial/serial_msm_geni.c
> +++ b/drivers/serial/serial_msm_geni.c
> @@ -183,7 +183,7 @@ static int geni_serial_set_clock_rate(struct udevice *dev, u64 rate)
>  	struct clk *clk;
>  	int ret;
>  
> -	clk = devm_clk_get(dev, "se-clk");
> +	clk = devm_clk_get(dev, NULL);
>  	if (!clk)
>  		return -EINVAL;
>  


More information about the U-Boot mailing list