[PATCH 5/6] serial: msm-geni: fix a compile time warning from msm_serial_setbrg()
Konrad Dybcio
konrad.dybcio at linaro.org
Fri Mar 31 03:29:51 CEST 2023
On 30.03.2023 21:47, Vladimir Zapolskiy wrote:
> A compiler warns about a missing function prototype, which is valid
> and fixed by converting the function into static one, also fix
> interleaved local variable declarations and assignments.
>
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy at linaro.org>
> ---
Fixes: 324df15a292e ("serial: qcom: add support for GENI serial driver")
Reviewed-by: Konrad Dybcio <konrad.dybcio at linaro.org>
Konrad
> drivers/serial/serial_msm_geni.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/serial/serial_msm_geni.c b/drivers/serial/serial_msm_geni.c
> index c9813f06ace7..03fc704182d3 100644
> --- a/drivers/serial/serial_msm_geni.c
> +++ b/drivers/serial/serial_msm_geni.c
> @@ -238,13 +238,13 @@ static inline void geni_serial_baud(phys_addr_t base_address, u32 clk_div,
> writel(s_clk_cfg, base_address + GENI_SER_S_CLK_CFG);
> }
>
> -int msm_serial_setbrg(struct udevice *dev, int baud)
> +static int msm_serial_setbrg(struct udevice *dev, int baud)
> {
> struct msm_serial_data *priv = dev_get_priv(dev);
> + u64 clk_rate;
> + u32 clk_div;
>
> priv->baud = baud;
> - u32 clk_div;
> - u64 clk_rate;
>
> clk_rate = get_clk_div_rate(baud, UART_OVERSAMPLING, &clk_div);
> geni_serial_set_clock_rate(dev, clk_rate);
More information about the U-Boot
mailing list